search

msupply-foundation / msupply-cold-chain

Android application for viewing and monitoring temperatures of fridges
GNU General Public License v3.0
3 stars 3 forks source link

#207 Add permission request to allow Android 10 export #208

Closed kat-ms closed 2 years ago

kat-ms commented 2 years ago

Fixes #207

As per PR title.

Tested on Lenovo M10 with Android 10 (didn't work before PR change but did after). On Android 8.1 and 11 it worked even without this update (did a sanity test on Android 11 and still works with this PR change included).

omsupply-bot[bot] commented 2 years ago

Beep boop! This pull request does not have an associated issue :(.

Chris-Petty commented 2 years ago

Just a thought- does the orange screen of doom need to pop up for this permission, or is that just for the location/bluetooth, not storage?

kat-ms commented 2 years ago

Just a thought- does the orange screen of doom need to pop up for this permission, or is that just for the location/bluetooth, not storage?

Hmm, it does currently (with this PR) pop up if it's not granted, although I'm not 100% sure whether it should (it doesn't technically stop the app from being usable - can still set up and collect data...but it's way less useful not being able to export 🤔 - would lean towards leaving it in?).

Chris-Petty commented 2 years ago

Ya leave it in sounds good!