msupply-foundation / msupply-cold-chain

Android application for viewing and monitoring temperatures of fridges
GNU General Public License v3.0
3 stars 3 forks source link

Temperature stuck due to dead sensor but no indication of sensor being dead #248

Open louisaw123 opened 1 year ago

louisaw123 commented 1 year ago

Describe the bug Blue Maestro small sensor stuck at -39 degrees and continued recording this temperature (screenshot). Battery sensor at the time 32%. On replacing the battery the sensor went back to normal.

History of Battery sensor %: 18/08/23: 44% [unable to get recordings in between this time due to no sync] 23/08/23: 36% 24/08.23: 32%

: Yep, they usually die around 32%. I was expecting it to go. When the battery dies, sometimes the data goes haywire & sometimes they just stop recording or transmitting or both.

To Reproduce ?when battery sensor reaches 32% - although this may be variable as sensors have been working at less than this

Expected behavior If the sensor is dead it should be dead and not able to record any data. However, this sensor is transmitting false temperature readings to the server and the battery % is still at 32% and so is not necessarily dead from a user perspective. If the sensor is dead it should stop transmitting any data and the battery should be 0%.

mark-prins commented 1 year ago

Unsure what the expected action is wrt to software changes sorry. It sounds like the sensor is still active and transmitting - are you suggesting the software should not accept data if the battery is below a certain threshold?

adamdewey commented 1 year ago

This happens when the sensor battery dies - it's actually quite a good indicator when it suddenly spikes to a large negative number.

Can we please hold off working on this for now as there are many higher priority issues than this we could work on.

@louisaw123 - can you remove the client details from this ticket (this is a public repo so anyone on the internet can read) - cheers!

louisaw123 commented 1 year ago

This happens when the sensor battery dies - it's actually quite a good indicator when it suddenly spikes to a large negative number.

Can we please hold off working on this for now as there are many higher priority issues than this we could work on.

@louisaw123 - can you remove the client details from this ticket (this is a public repo so anyone on the internet can read) - cheers!

removed! thanks!

adamdewey commented 1 year ago

Thanks @louisaw123 :))

mark-prins commented 7 months ago

perhaps not an issue with the longer battery life?