search

msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
20 stars 12 forks source link

Add KDD for service charges #1323

Open andreievg opened 1 year ago

andreievg commented 1 year ago

As noticed in https://github.com/openmsupply/open-msupply/pull/1311#pullrequestreview-1336095651, in omSupply we deal with service charge in a different manner.

Add a KDD explaining the reason we added service charge as invoice_line with service type item.

KDD should include:

andreievg commented 1 year ago

Main reason was ability to add multiple service charges and categorise what the charge is for.

regotaina commented 5 months ago

[reposting]

I followed the instructions to add service charges to the masterlist on OG server. This enabled the "add" button on OMS:

telegram-cloud-photo-size-1-4904727651760057836-y

which is great. However, I can edit the price line at OMS and the price can be completely different than set up on central server:

telegram-cloud-photo-size-1-4904727651760057837-y

that's the final outcome. Price on central server = $10, price on OMS $150.

Which leads me to think there is not a lot of sense to have this set up on central server level, within masterlists, , if the outcome is just enabling a button to add charges on OMS.

discussed the results with @roxy-dao