msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
19 stars 12 forks source link

Backdate location for berlinger data points #2597

Open andreievg opened 7 months ago

andreievg commented 7 months ago

From epic: https://github.com/msupply-foundation/open-msupply/issues/2423

Location should be linked to fridge tag differently to how it's linked to blue maestro, since the former is uploaded less frequently. We thought about adding a modal when fridge tag data is integrated, to allow user to select location. Maybe simpler solution for now is to back date selected location for temperature logs and breaches when it's selected ? But then how do we manage when location is cleared ? When say fridge tag is moved to another fridge. And also how do we manage sensor down time (when say it's not in a fridge for a bit ? Which is very likely for fridge tag, since it's taken out of the fridge to sync data from it). Btw we've settled on setting and removing location as the way to tell the system that sensor is inactive/active (for like battery change and relocation of blue maestro).

Proposed solution (for 1.6.0)

When location is updated on fridge tag sensor, back date location for all data points and breaches to this location. Data points/breaches that were already linked to a location should not be updated.

What about if location was changed to 'none', and then changed to another location ?

Please note there are some discussion about this on the epic

andreievg commented 4 days ago

Removing from milestone and changing priority as should have, work is not planned for 2.2 and reduce priority