search

msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
20 stars 12 forks source link

Breach acknowledgement status for fridge tag data #2599

Open andreievg opened 8 months ago

andreievg commented 8 months ago

From epic: https://github.com/msupply-foundation/open-msupply/issues/2423

Form my understanding, current fridge tag data will always show breaches at unacknowledged, and since we don't have manual acknowledgement of breaches yet (manual as in in omSupply), I wonder what we should do ?

@adrianwb, sorry if this was answered already, can we acknowledge breaches with fridge tags (via the device) and it this recorded in the text files ?

@adamdewey if no, then what should we do for now ? Should we treat them as acknowledged? Should we remove the acknowledges statuses from UI for now ?

adamdewey commented 8 months ago

@andreievg - It seems that users can perform a 'Confirm' action on breaches:

image

I'm not sure how that's reflected in the data sent to us by the Fridge-tag though?

If we can't determine if a breach has been acknowledged or not on the Fridge-tag then, yeah, I agree we should remove the concept of acknowledged/unacknowledged for Fridge-tag data from the UI. Unsure how easy that is though?

adamdewey commented 5 months ago

So, since this issue was raised we have added manual acknowledgment of breaches to Open mSupply.

Furthermore we are disregarding any breach acknowledgment states sent by sensors to Open mSupply.

However there is still a question mark about how best to handle breach acknowledgements for Fridge-tags.

If the Fridge-tag is breaching at the time the PDF file is generated, Open mSupply will continue to show the Fridge-tag breach as ongoing until it receives a subsequent non-breach temperature log.

Currently Open mSupply doesn't allow users to acknowledge an ongoing breach.

That could be a long time for the system to show an ongoing breach if the Fridge-tag is only plugged in once a week or longer..

There is some related discussion in #3207

andreievg commented 1 month ago

Removed milestone and removed from sprint, pending refinement. Work is not planned in 2.2

adamdewey commented 1 month ago

May become more relevant if a certain client goes ahead with Open mSupply as they're planning to use Berlinger Fridge-tags