msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
20 stars 12 forks source link

Merging: Rename InvoiceRow::clinician_id to clinician_link_id #2842

Closed Chris-Petty closed 8 months ago

Chris-Petty commented 8 months ago

Is your feature request related to a problem? Please describe 👀

After the first merge of the feature/merging branch column renames should be removed, e.g:

    #[column_name = "name_link_id"]
    pub name_id: String,

The reason is that all query method exped a name_id but with the current code we use a name_link_id. Thus a query would fail for merged names/items.

Same changes should be applied for item_id/item_link_id.

See past similar issues for example PRs.

Moneyworks Jobcode 🧰

OMS:MERGE

clemens-msupply commented 8 months ago

Already done