msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
20 stars 12 forks source link

Inbound/Outbound returns: naming cleanup (3h) #3188

Open lache-melvin opened 6 months ago

lache-melvin commented 6 months ago

Epic #2897

Is your feature request related to a problem? Please describe 👀

There is some inconsistent/confusing naming that should be resolved:

Could moving the generate_lines queries out of general and into invoice_queries here too? 🙏 And move update_lines from invoice to invoice_line mutations!

Additional context 💌

This should probably be done at the end, in case we have any other naming things that we catch along the way.

andreievg commented 6 months ago

Diagrams need updating and adding to internal readme.md files somewhere

andreievg commented 3 months ago

Refinement, it sounds like some naming may still change on front end, might be worth waiting till then: https://github.com/msupply-foundation/open-msupply/issues/4113