search

msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
20 stars 12 forks source link

Rounding number inconsistencies under Items -> SOH/AMC/MOS #3467

Open marthakeezy opened 5 months ago

marthakeezy commented 5 months ago

This issue is replacing #3351

What went wrong? 😲

During release testing V1.7.0, I discovered the AMC column in 'List' view shows 2 decimal points, whereas if you click into a specific item, AMC will only show 1 decimal point, rounded. **Concern #1:** the view/number of decimal points should be consistent across the platform, e.g. we should only ever show either 1 decimal point, or 2, but not a combination of both. Concern #2: I noticed under Amoxicillin 500mg tabs, MOS in 'List' view was showing 0.55 months of stock, but when clicking into the item it turns into 0.5 months of stock. ## Expected behaviour 🤔 Decimal points shown should be consistent across the platform, e.g. as mentioned above, we should show either 1 decimal point, or 2 decimal points, but not a combination of two. Rounding up/down should also be consistent. ## How to Reproduce 🔨 Steps to reproduce the behaviour: 1. Go to Items 2. Scroll down until you see an item with all three columns populated for easy testing 3. Take note of the numbers you see -> then click into this item for a detailed view 4. Note the discrepancy ## Your environment 🌱
marthakeezy commented 5 months ago

Actually, to add to that:

When comparing 'List' view to detailed item view:

SOH -> Available Stock (completely different wording) AMC -> AMC (abbreviation stays the same) MOH -> Months of Stock (same abbreviation, but expanded)

Speaking of consistency, can we perhaps change the wording to be:

Screenshot 2024-03-20 at 4 47 47 PM Screenshot 2024-03-20 at 4 47 55 PM
marthakeezy commented 5 months ago

@roxy-dao @Chris-Petty @richardmoizeau ^

roxy-dao commented 5 months ago

Actually, to add to that:

When comparing 'List' view to detailed item view:

SOH -> Available Stock (completely different wording) AMC -> AMC (abbreviation stays the same) MOH -> Months of Stock (same abbreviation, but expanded)

Speaking of consistency, can we perhaps change the wording to be:

  • either all completely different
  • or all abbreviations
  • or all abbreviations, but expanded? Because currently, all three columns follow their own convention :)

There's already a big overall issue to fix these consistencies but will require a lot of work.