msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
23 stars 14 forks source link

Service item from outbound shipment syncs as a dummy line to the ci of the mSupply #3554

Open raviSussol opened 7 months ago

raviSussol commented 7 months ago

What went wrong? 😲

Origin of #3545 At the moment, service charge added in the outbound shipment syncs as a dummy line in the customer invoice of the mSupply. This is because of pack size, no. of packs with other price fields are being 0 (of the service charge item) in the oms. Does that mean the service charge feature only need to be in oms (not in the msupply)? What is the reason behind mapping service charge (in oms) to the service item (in the msupply) though? In the msupply, service item has default pack size to 1 and it uses default sell price in the ci. Above all what is the expected behavior for service charge both in the oms (created from) and the ms (received after sync)? ## Expected behaviour 🤔 ## Screenshots ![Screenshot 2024-04-05 at 12 42 13 PM](https://github.com/msupply-foundation/open-msupply/assets/13145522/c73d8a82-dba0-45b4-bf24-e77d82ce81d0) ![Screenshot 2024-04-05 at 12 39 44 PM](https://github.com/msupply-foundation/open-msupply/assets/13145522/1f3ae5dc-6adb-452d-b62c-71743df50dbf) ## How to Reproduce 🔨 Steps to reproduce the behaviour: 1. Create a outbound with some line. Better to have line totals 2. From More > Add service charges - some values so that Grand total>Line total 3. Confirm the shipment to Shipped status 4. The grand-total is adjusted to line-total 5. Now sync it and in the mSupply > customer invoice 6. See the dummy line with pack size, quantity, sell price to 0 ## Your environment 🌱
roxy-dao commented 6 months ago

Add to #1323

mark-prins commented 5 months ago

Waiting for the outcome of the KDD process before we proceed with this one