Circular sync of currencies

[andreievg]

What went wrong? 😲

While on demo server i noticed that sync is circular:

https://github.com/msupply-foundation/open-msupply/assets/26194949/38bbf0fe-18be-469b-9772-c6b28933575e

I ran this in postgres on demo server:

select * from changelog_deduped order by cursor DESC limit 3

And got this (after each re-sync)

Expected behaviour 🤔

Should not have circular sync

How to Reproduce 🔨

I haven't tried to re-produce sorry, but would suggest trying to add currencies locally (sorry not familiar with this area)

Steps to reproduce the behaviour:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Your environment 🌱

Demo server 1.7.00

[andreievg]

Would be great to have circular sync checks be added to some overall test case, not currency specific, but now and again for testers to do manual sync, and if looks circular to share database

[Chris-Petty]

Hmm I think @nisha-dangol did notice that there are some odd sync records that seem to always be present. Is weird that it's currencies as they don't even have a push translator, how can it be ?

[nishaDangol-Sussol]

Hmm I think @nisha-dangol did notice that there are some odd sync records that seem to always be present.

I submitted issue regarding that wrong sync numbers last time: #3447

[andreievg]

@Chris-Petty since there is no push translator, it might not be circular sync, but looks like we are pulling those 3 records all the time ? Since changelog is updated ?

[Chris-Petty]

Note for future assignee - need to reproduce, determine what's happening and propose a fix. Might be a mSupply Legacy problem rather than OMS!