Create Stocktake Modal - filter selection

[lache-melvin]

The "New Stocktake" button launches a modal with the following options:

It's particularly limiting since, as soon as you select one of the inputs, any previous inputs are cleared, so you can't select multiple criteria. And having the UI jump around on you like a game of whack-a-mole is poor user experience.

Describe the solution you'd like 🎁

1. Improve the "New Stocktake" modal to make these criteria multi-selectable, which would result in "AND" filtering for the new stocktake
2. We would also like to be able to create new stocktakes from any particularly stock filtering criteria. We can filter stock using the filters available in the "View Stock" list. We should then have a button to "Create a new stocktake from current filters".

So basically, for a quick way to create a stocktake, or to create one from a Master list, use the existing "New Stocktake" modal (but with inclusive selection critieria). And to create a stocktake from any arbitrarily filter list of stock lines, use the Stock filters and create a new stocktake from that.

Describe alternatives you've considered 💭

Just do only one of the above suggestions?

Additional context 💌

Some considerations and details to be worked out:

• The back-end "insert stocktake" service currently only handles the four exclusive filtering options, so we'd need to improve this to take a standard full filter object (the repository layer is already doing this, so shouldn't be too bad)
• Where do we put the "New Stock from filtered" button on the View Stock page? My inclination is to put it as an "action" in the "Actions" dropdown we have on list pages. The only problem with that is that these actions normally act on selected items, but in this case we want it to act on the current full list (including ones that might be on another page). Is this too much of a departure from standard practice? The other option is to have it as a button at the top. We could hide it until at least one filter is applied, perhaps?

Moneyworks Jobcode 🧰

🤷‍♂️

[roxy-dao]

More info? 👀

[CarlosNZ]

More info? 👀

Coming... :)

[Chris-Petty]

Going by the description I'd 100% call this a bug if not an enhancement, not a refactor 😁. The solution would be point 1., point 2. sounds like an enhancement issue, those filters for reference:

And the dialog/wizard for making a new stocktake in legacy (note all filters are default or strictly "AND"):

The only biggg one really missing right now is a name/code filter, reasonable to add I think!

[Chris-Petty]

Call me out if masquerading as a designer too much, but I think all the explainer in the modal text is unnecessary!