msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.

https://msupply.foundation/open-msupply/

GNU Affero General Public License v3.0

17 stars 11 forks source link

3739 remove foreign key for user #3896

Closed jmbrunskill closed 2 weeks ago

jmbrunskill commented 2 weeks ago

Fixes #3739

👩🏻‍💻 What does this PR do?

Removes foreign key from asset_log to user_account so if a user isn't available on central OMS it doesn't prevent sync from happening.

💌 Any notes for the reviewer?

Roxy's PR https://github.com/msupply-foundation/open-msupply/pull/3431 to sync user information could potentially solve this? But doesn't appear to be working for me.

This PR msupply suggests that changes to user account might not trigger sync? https://github.com/msupply-foundation/msupply/pull/14538

🧪 Testing

[ ] OMS Central Sync server with an OMS remote site running this PR
[ ] Login to OMS Remote with user that hasn't logged into Central
[ ] Create an asset
[ ] Create a status log
[ ] Sync to Central
[ ] Login to Central with different user
[ ] Check that the asset and status both synced correctly.

📃 Documentation

[x] No documentation required: no user facing changes or a bug fix which isn't a change in behaviour

github-actions[bot] commented 2 weeks ago

Bundle size difference

Comparing this PR to main

Old size	New size	Diff
8.72 MB	8.72 MB	3.5 KB (0.04%)

roxy-dao commented 2 weeks ago

https://github.com/msupply-foundation/msupply/pull/14538 can solve this with 3431 changes, but will need whoever creates users to press the button