Temperature Monitoring: Incorrect breaches displayed on graph

msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.

https://msupply.foundation/open-msupply/

Other

20 stars 12 forks source link

Temperature Monitoring: Incorrect breaches displayed on graph #3956

Open adamdewey opened 1 month ago

adamdewey commented 1 month ago

What went wrong? 😲

Breaches that are far outside the date range are being displayed on the graph:

Expected behaviour 🤔

Graph should only display breaches that contain logs that fall in the date range specified.

How to Reproduce 🔨

Steps to reproduce the behaviour:

Unsure exactly - haven't had time to investigate properly, sorry!

Your environment 🌱

Open mSupply Version: v2.0.00
Legacy mSupply Central Server Version: 7-14-04
Device: Samsung tablet

jmbrunskill commented 1 month ago

@adamdewey can you provide the sqlite file to me?

adamdewey commented 1 month ago

@jmbrunskill - sure, here you go: https://drive.google.com/file/d/1CIIx3wKeg2BaCKDH66k60FXhtHkRktCv/view?usp=sharing

andreievg commented 1 month ago

daily triage: Setting priority to normal and leaving for fortnightly triage, I think we need to deep think about how much more time we invest into this, and I think have a thorough design of this work, I think ever since it's sneaked in through in MVP, there has been a lot of issues (we were not meant to do it for cold chain MVP because it required a lot of thought about all of the use cases)

roxy-dao commented 1 month ago

If quick fix. Fix. Otherwise, leave it for now