search

msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
19 stars 12 forks source link

Repack `New Location` showing as old `Location` (new shows blank) #4010

Open lache-melvin opened 1 month ago

lache-melvin commented 1 month ago

What went wrong? 😲

When looking at a historic repack, it shows the updated location on the left with the "original data", and shows nothing for the "new location":

https://github.com/msupply-foundation/open-msupply/assets/55115239/8b52a08f-49b2-4f7b-931b-8331b6a5ebf2

i.e. Why are these different?

Editing: Screenshot 2024-05-28 at 9 53 31 AM

Saved: Screenshot 2024-05-28 at 9 53 39 AM

Expected behaviour 🤔

Old location on the left, new location on the right Triage comment not sure if we have the old location, or if it is easily attainable. Populate if it is available, but we are fine if only the new location is displayed on the right.

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Go to a stock line
  2. Create a repack, and move that new stock to a new location
  3. Save
  4. View your repack line
  5. BUG: See your inputted new location on the left, and empty New location field on the right

Your environment 🌱

lache-melvin commented 1 month ago

Daily triage: setting to normal - it's appears wrong, which isn't ideal, but just for display (not actually breaking any workflow)

roxy-dao commented 1 month ago

I think we did this on purpose 🤔 . The location on the repacks is correct... it doesn't have a new location.. that's only enabled for new repacks and refers to the location that it will be moving to. Once it's been finalised, it's not new anymore XD

mark-prins commented 1 month ago

Looking at the vid - it does feel deliberate. the LHS shows the current location of the stock. It would be confusing for me to have old and new locations populated.

So my view is that it isn't wrong at all. Possibly would be useful to have a mention in the log that the original stock was in location x and this is in location y, but not required atm.

my advice is to close the issue

lache-melvin commented 1 month ago

Ok... but LHS has old number of packs and pack size? Seems really weird to me to colocate that with the new location?

If not showing old location (though that sort of does feel useful too... where did the stock move from?) it would make more sense to me to leave the LHS location blank and the RHS one showing the updated location?

mark-prins commented 1 month ago

yes, I see that now. I was thinking of looking at the repack itself, not the historic repack on an existing stock line. agree - should change

mark-prins commented 1 month ago

Refinement old location available.. add that in too please

mark-prins commented 3 days ago

moving out of 2.2 due to workload. it's not broken, just bad.