search

msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
23 stars 14 forks source link

iSC/Cold chain: fixed range for date filters excludes breaches that might be ongoing #4251

Open marthakeezy opened 5 months ago

marthakeezy commented 5 months ago

What went wrong? 😲

Cold chain -> Monitoring

When accessing Monitoring, by default the date filter will only show the last 24 hours. While date filter is editable, the first glance the user gets would be the last 24 hours. The filter value remains the same across all three tabs - Monitoring, Breaches and Log.

Screenshot 2024-06-24 at 4 19 13 PM

Cold chain -> Breaches

Because of the filter described above, the breaches actually do not show up unless they happened in the last 24 hours. So the beginning time of the breach has to fall within the date range that is set by default for the user to see it straight away without having to change any details.

I wonder if it creates a false picture of the site having no breaches. Because the first screen the user sees is 'No Temperature Breaches Found' and the users might not even realise they have date filters on or might not pay attention. I definitely got caught by this the first time I used Cold chain after the filters were fixed, and it took me solid 10 minutes to figure out breaches don't show up because of the filter.

Screenshot 2024-06-24 at 4 19 40 PM

Expected behaviour 🤔

I think it would be really good to either:

@adamdewey might have more thoughts on what would be best for the user :) I personally think default date filter would be good to minimise the information shown on the screen straight away, but we need to have exceptions for the ongoing breaches or those, that haven't been acknowledged.

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Produce a breach that is older than 24 hours
  2. Go to Cold chain -> Monitoring
  3. Note the default date/time in the date filter
  4. Navigate to Breaches -> see the breach that is older than your time range not appear
  5. Confusing!

Your environment 🌱

marthakeezy commented 5 months ago

Marked as Severity: Normal as in my opinion it's impacting the users who don't pay heaps of attention and will only glance over, and once they see there are no issues they wouldn't think twice to check if anything is wrong and rather trust what the screen is showing. The only reason I went digging was because I knew there should definitely be a breach and for some reason it wasn't showing :)

andreievg commented 5 months ago

Triage, waiting for @adamdewey to decide on severity

adamdewey commented 4 months ago

Yes, agree - the tab should show breaches that have any part of them that fall within the current date range.

Should apply to both ongoing and ended.

adamdewey commented 4 months ago

Severity Normal is good

andreievg commented 3 months ago

Functionally makes sense to include ongoing breach. Maybe a little bit harder on technical end, because of end date time not populated before breach is finished.