search

msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
23 stars 14 forks source link

GAPS: Capture stock safety buffer for facilities #4370

Closed adamdewey closed 2 weeks ago

adamdewey commented 4 months ago

Is your feature request related to a problem? Please describe 👀

Describe the solution you'd like 🎁

Describe alternatives you've considered 💭

Additional context 💌

User story B.2.13
As a… National EPI manager
I want… to specify stock safety buffer values for each facility in months
So that… our forecasting can use this to calculate the maximum amount of each type of vaccine that can be expected to be stored at each facility at any point during the year

Solution B.2.13

The system will provide a mechanism for central users to enter a figure to represent the stock safety buffer in months for each facility.

This will be the number of months to represent the supply that facilities keep in reserve in case of issues with deliveries.

The interval will apply to all commodities, not to individual types of vaccine.

Note: the wording has changed from the original user story in the design doc as UNICEF clarified that

"The values are assigned at the central level guided by the iSCM/EPI policy/Manual."

Moneyworks Jobcode 🧰

CCEIDEV

adamdewey commented 4 months ago

There is an OG store setting that already captures this value - however we should group the supply interval value along with this safety buffer value (supply interval value doesn't exist in OG afaik)

We should display the values in OMS as non-editable so that it's easy for users to view without having to look in OG

mark-prins commented 3 months ago

Would that be the store pref for Threshold for understock? Are you suggesting that we take the value for that, and display alongside a new facility property for 'supply interval', with the former as read-only?

adamdewey commented 3 months ago

Would that be the store pref for Threshold for understock?

Yes that's the one!

Are you suggesting that we take the value for that, and display alongside a new facility property for 'supply interval', with the former as read-only?

Either that or we create an OMS version too and don't bring across the OG one when it's finally time to port it across to OMS?

mark-prins commented 3 months ago

..or we create a new one and have the sync code (from OG) read the store pref and populate the new property if it's blank 🤔

cool - thanks Adam, we can make something work 🙏

lache-melvin commented 3 weeks ago

the "Threshold for understock" is being synced from OG already store_preference.months_understock, being used for reports. Let's display this in the store properties modal as read only field.

Given store properties are just a JSON object on name at the moment, I think easiest to query/display the months_understock store pref (read only) separately, display that, then show the rest of the fields below (rather than trying to do anything tricky in sync, adding/overwriting name properties...)

Maybe investigate whether we can move Supply interval to the top (or bottom, not sure where it makes more sense?) so interval and buffer are shown together!

Can be resolved whenever we start to port more of these prefs over to OMS central.

Image

lache-melvin commented 2 weeks ago

Upon closer look, the existing 'months understock' store pref is on the store, rather than the name record, and so only exists for stores rather than facilities too. I thought it would be great to be able to reuse, but I think might cause more headaches than help... We'll add another facility property, and ignore the store pref there. Mark says to call it a feature, you can independently configure the buffer value without messing up your ordering parameters!