msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
20 stars 12 forks source link

Layout of date picker on tablet is ugly #4628

Closed adamdewey closed 3 weeks ago

adamdewey commented 4 weeks ago

What went wrong? 😲

The layout of the date-picker doesn't look finished, e.g. the time is large and off-center compared to the date:

telegram-cloud-photo-size-1-5051257534874234274-y

Expected behaviour 🤔

It should look nicely formatted / deliberate

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Go to Cold Chain > Monitoring
  2. Open the date picker

Your environment 🌱

mark-prins commented 4 weeks ago

Note that this is the default material UI datepicker formatting. here's how their demo looks

image

adamdewey commented 4 weeks ago

Interesting.

I would say that we probably don't need seconds in our date picker - that could give us some real estate back if we limit only to minutes?

andreievg commented 4 weeks ago

I would say that we probably don't need seconds in our date picker - that could give us some real estate back if we limit only to minutes?

I don't think we have an option to adjust ? An alternative is to use: https://capawesome.io/plugins/datetime-picker/ for android or to write picked ourselves (we did it for Conforma, so could take that and re-style + add time picker). Mui date picker is actually pretty chunky (bundle size wise), so maybe worth considering, but doubt we have time for it

andreievg commented 4 weeks ago

Daily triage, not a hot fix candidate so leaving for weekly triage

adamdewey commented 4 weeks ago

I don't think we have an option to adjust ?

Oh, I was assuming there was some config option because in their screenshot it doesn't show seconds?

mark-prins commented 4 weeks ago

yep, it's config - we are deliberately showing seconds 🙄

how do you like them apples?

image
adamdewey commented 3 weeks ago

I like them apples heaps better!