msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
23 stars 15 forks source link

R&R Forms changes #4810

Closed mark-prins closed 3 weeks ago

mark-prins commented 1 month ago

Is your feature request related to a problem? Please describe πŸ‘€

Some requests from the client re the R&R forms.

Describe the solution you'd like 🎁

I don't want the very specific column name requests to be applied to all users, would it be possible to find a solution which makes the column names customisable in some way? Similarly, I'm not certain that all users would require the additional columns. Could these be bespoke?

Rename columns

New columns ( proposed )

System enhancements

Describe alternatives you've considered πŸ’­

Additional context πŸ’Œ

Moneyworks Jobcode 🧰

mark-prins commented 1 month ago

If #4060 is done - perhaps we can use a server-delivered custom namespace which has the override column name translations?

jmbrunskill commented 1 month ago

Custom translations Issue - #5061

lache-melvin commented 3 weeks ago

Capturing some Telegram decisions here:

lache-melvin commented 3 weeks ago

Closed by #5180

AnushaUp commented 3 weeks ago

πŸ§ͺ Testing

Tested in V2.3.1-rc1

AnushaUp commented 3 weeks ago

@lache-melvin here the value of Maximum and Minimum seems like 1 is added in each one for eg here for minimum 113 3 = 339 but here 340 is shown and same for the maximum where the value should be 113 6 = 678 Screenshot 2024-10-24 at 3 07 36 pm

lache-melvin commented 3 weeks ago

@AnushaUp I am wondering if you hover/press on those fields so the tooltips show, are they actually decimals that are getting rounded? e.g. 113.2 * 3 = 339.6, which would get rounded to 340 πŸ‘€

AnushaUp commented 3 weeks ago

@lache-melvin Make sense. Thanks! I was a little confused with the first point. Migration from oms?

lache-melvin commented 2 weeks ago

Migration from oms?

Ah sorry great question! I meant upgrade - have some R&R forms in 2.3.0, upgrade to 2.3.1, no errors

marthakeezy commented 2 weeks ago

Gave this a test, migrations look good and don't seem to affect R&R forms. Logged a few bugs (#5274, #5279), otherwise looks good. Moving to Done βœ