No translation electron client on windows

[andreievg]

What went wrong? 😲

@adamdewey noticed during deployment that client app does not have translations on the discovery screen:

After some investigations we found that client app tries to access translations from:

C:\Program Files\Open mSupply Desktop\resources\app\.webpack\renderer\main_window

Locale files are located in C:\Program Files\Open mSupply Desktop\resources\app\.webpack\renderer\

It looks like there is some caching which allows client to still use cached translations after re-install (this can be cleared by going to help -> developer tools -> application tab and clearing local storage, after which I get the same error on a cloud test server), relocating locale files to main_window seems to fix this, made a test tag from this branch, which is branched from this release, which just adds an extra place for locales to be moved after build

https://github.com/msupply-foundation/open-msupply/blob/56478af998b74b61f72e8aa6336f7f00fcf7fa67/client/packages/electron/webpack.plugins.ts#L36

Expected behaviour 🤔

Translations present in client app

How to Reproduce 🔨

Install v2.2.2 client app, clear cache completely by going to help -> developer tools -> application tab and clearing local storage, after app restart translations will be missing from client app (can go to the bottom right 'edit' next to server IP address to go back to discovery, if already connected to server)

Your environment 🌱

• Open mSupply Version: v2.2.2
• Legacy mSupply Central Server Version:
• Platform: Desktop Client App
• Database type:

[lache-melvin]

Closing as was not reproducible in V2.2.3-RC1, might have been a build issue with v2.2.2

[lache-melvin]

Reopening, this was found again on this test build: v2.4.0-TEST_LL

Needs investigation - do we have a flaky build step? Or is something else causing the issue?

[andreievg]

Triage, if installer is tested with re-installation, we should be pretty safe