search

msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
23 stars 15 forks source link

Can't mark an Inbound Shipment as 'Delivered' without it affecting current stock levels #4890

Open adamdewey opened 1 month ago

adamdewey commented 1 month ago

What went wrong? 😲

The current workflow does not allow a user to confirm receipt of a delivery without triggering stock levels to be updated, regardless of whether they have had time to verify the contents of the delivery or not.

These steps are separate in medium to large facilities as it takes time to verify the contents.

It would be preferable to wait until the delivery has been marked as 'Verified' to update stock levels.

As soon as this is marked as 'Delivered', the stock levels will be increased by 800 and can be distributed to customers (even if the stock doesn't actually exist):

telegram-cloud-photo-size-1-5163525153903193193-y

Expected behaviour 🤔

Stock levels should not be updated until the delivery is 'Verified'

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Open a new Inbound Shipment
  2. Mark the shipment as 'Delivered'
  3. Note stock levels have been updated

Your environment 🌱

lache-melvin commented 1 month ago

Adding needs design, probably PO/PM input, sounds like expected behaviour not quite confirmed... per Telegram, maybe delivered stock is introduced but on hold?

Gwalior-84 commented 1 month ago

Alternative would be that delivered stock be like an unconfirmed SI in Legacy mSupply: Not in stock. But I like the in-stock but on-hold option better - as it lets the user know that they would have stock available for issue if they got around to verifying the inbound shipment!

andreievg commented 1 month ago

Triage must have and needs design, would be great to have clarity about this as soon as possible

mariyamsupply commented 1 month ago

Introducing 2 ideas:

  1. Simple 'Update status' multi-button (similar to what we have, just different wording). And we Don't trigger stock lvl updates until 'Finalised'
Simple update status
  1. 'Update status' button opens a modal with more info, we can explain what happens to the stock lvl, when they need to wait for an update from another site, etc 'On hold' might be one of the statuses
More info update status on hold shipped finalise

Also, Small facilities asked if they can have just one 'Finalise' button (no need to update status)