msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
21 stars 12 forks source link

Errors with migrations aren't reported well on Windows #5069

Open jmbrunskill opened 2 weeks ago

jmbrunskill commented 2 weeks ago

What went wrong? 😲

2024-10-10 06:14:58.889242300 [ERROR] <windows\src/windows.rs:71>:panic occurred PanicHookInfo { payload: Any { .. }, location: Location { file: "library\\core\\src\\panicking.rs", line: 221, col: 5 }, can_unwind: false, force_no_backtrace: false }
2024-10-10 06:15:12.363238200 [ERROR] <windows\src/windows.rs:71>:panic occurred PanicHookInfo { payload: Any { .. }, location: Location { file: "C:\\Users\\Administrator\\AppData\\Local\\Jenkins\\.jenkins\\workspace\\omSupplyMain\\server\\server\\src/lib.rs", line: 89, col: 10 }, can_unwind: true, force_no_backtrace: false }
2024-10-10 06:15:12.389440500 [ERROR] <windows\src/windows.rs:71>:panic occurred PanicHookInfo { payload: Any { .. }, location: Location { file: "library\\core\\src\\panicking.rs", line: 221, col: 5 }, can_unwind: false, force_no_backtrace: false }

Expected behaviour πŸ€”

Error message should say, unable to run migrations and ideally an idea what the migration error was (if there's more debug availble)

How to Reproduce πŸ”¨

Steps to reproduce the behaviour:

  1. Create a broken migration
  2. Start service on Windows
  3. Check error log

Your environment 🌱

lache-melvin commented 1 week ago

Error message should be getting mapped through, and I think worth investigating why. Setting as normal just seeing as at least we get the line number, we know where to start looking