search

msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
20 stars 12 forks source link

Cannot delete lines - error message could be clearer #5128

Open regotaina opened 2 days ago

regotaina commented 2 days ago

What went wrong? 😲

found accidentally while testing remote authorisation.

In Requisitions received from a store, you cannot delete any lines. Expected behaviour. However message is currently "deleted response lines not yet implemented in API" which can be confusing for users.

Screenshot 2024-10-15 at 2 24 11 PM

Expected behaviour 🤔

Possible alternative text like " you cannot delete lines of this requisition"

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Create IO from Store A to supplying Store B
  2. Confirm sent
  3. Login to Store B
  4. Go to Requisitions
  5. Try to delete any line from the requisition received form Store A
  6. See error message

Your environment 🌱

lache-melvin commented 1 day ago

If deleting response requisition lines isn't supported yet, shouldn't we just remove the delete selected lines action from the UI?

roxy-dao commented 1 day ago

If deleting response requisition lines isn't supported yet, shouldn't we just remove the delete selected lines action from the UI?

Should be implemented for manual requisitions though... in case someone does add a wrong line?

lache-melvin commented 1 day ago

Should be implemented for manual requisitions though... in case someone does add a wrong line?

Ah great point! Maybe this one can be resolved as part of manual requisition work 🙏