search

msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
23 stars 15 forks source link

'Finalise the previous R&R form in this schedule to create the next one' warning shows up even before the schedule is selected for an R&R Form #5279

Open marthakeezy opened 2 weeks ago

marthakeezy commented 2 weeks ago

What went wrong? 😲

When creating a new R&R form, the warning Finalise the previous R&R form in this schedule to create the next one shows up even before the schedule is selected. My suspicion is as soon as an R&R form for a Program is created, the warning shows up regardless of the schedule previously selected. Also, curious to why the warning shows up below Period and not Schedule?

It can be quite misleading for the user is the warning shows up before they even attempt to select anything?

Video of the behaviour ->>> here

Expected behaviour 🤔

No warning unless affected schedules are selected, otherwise they should be able to select the schedule they need

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Go to Replenishment -> R&R Forms
  2. Create a new R&R Form for a Program that has multiple schedules
  3. Create a second R&R Form for the same Program - see warning show up even when there are other schedules available to choose from
  4. Misleading?

Your environment 🌱

lache-melvin commented 2 weeks ago

If you have a previous form, the schedule should be pre-populated... that should be why the error message is showing!