search

msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
23 stars 15 forks source link

Stocktake: insert error explanation #5297

Open mark-prins opened 1 week ago

mark-prins commented 1 week ago

Is your feature request related to a problem? Please describe 👀

Given this error: telegram-cloud-photo-size-1-4990080244048309464-y

Can we have a way of seeing the actual batch, and a way to resolve the problem please?

See also #4035 and #3285

Describe the solution you'd like 🎁

Instead of a toast notification which disappears quickly and can only display limited information, could we show a modal and have links to the affected batches?

Currently it is hard to know how to fix the issue. Having more information would be useful - at the least, display the name of the item and the batch. Ideally it should have a link to the batch, so that you can edit the hold status.

Describe alternatives you've considered 💭

Additional context 💌

Moneyworks Jobcode 🧰

GaryWilletts commented 1 week ago

@mark-prins why is there a check if a line is on hold? Stocktakes don't care, you're just doing the count, same with inventory adjustments. Other outbound transactions do care but not stocktakes or inventory adjustments I thought. This is true in OG anyway

andreievg commented 6 days ago

Hmm we already have a mechanism for displaying errors, but there is some ambiguity about that mechanism. I set needs refinement and high priority for one of the issues that @mark-prins linked. For this one, for now we can ignore this error for stocktake, on backend. Also added needs refinement and high

andreievg commented 5 days ago

After refinement, the proposed solution is two part (first higher priority then the second):

1 - allow on hold stocklines to be adjustable in stocktakes. 2 - error to be mapped or displayed correctly, would require more structured error here so it doesn't throw an error here

andreievg commented 5 days ago

Also added another issue here: https://github.com/msupply-foundation/open-msupply/issues/5363