search

msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
23 stars 14 forks source link

Wrong prompt showing when trying to set quantities to 0 with no item selection in Inbound Shipments #5614

Open marthakeezy opened 2 days ago

marthakeezy commented 2 days ago

What went wrong? 😲

When trying to use the 'Set quantities to 0' function with no actual item selection, the wrong prompt pops up (you can see the same one when trying to delete lines without actually selecting them)

Video of the bug ->>> here

Expected behaviour 🤔

Should have its own prompt, for example select lines to set the quantity to 0

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Go to Replenishment -> Inbound Shipments
  2. Create a new Inbound Shipment or edit an existing one
  3. Add a few items to the shipment
  4. Without making a selection, click on the Actions dropdown in the top right corner and try to set the quantities to 0
  5. You will see the same prompt as to when you try and remove the lines without actually deleting them
  6. Error!

Your environment 🌱

roxy-dao commented 2 days ago

Do you have the row selected? 🤔

marthakeezy commented 2 days ago

No rows selected (hence the prompt), but it says 'delete' even when trying to set the quantity to 0 - which it shouldn't?