msupply-foundation / openmsupply-client

Someone should really write a description for this repo.
2 stars 0 forks source link

1240 android usability #1243

Closed mark-prins closed 2 years ago

mark-prins commented 2 years ago

Fixes #1240

Improves the usability of the android app. There's one issue outstanding with printing, will raise a separate issue for that one.

The changes in this update are:

Originally, when adding an item to an outbound shipment the view was:

add-item-landscape

With the changes, the view in portrait is usable: add-item-portrait

and the landscape view is too: add-item-landscape-new

If you'd like to test, here's an APK which includes the changes: https://drive.google.com/drive/u/2/folders/111xxY1rdSTxXwXfza9Y-kiVSEaSQcuCj

github-actions[bot] commented 2 years ago

Bundle size difference

Comparing this PR to main

Old size New size Diff
3.84 MB 3.85 MB 9.73 KB (0.25%)
mark-prins commented 2 years ago

Doh! sorry @clemens-msupply - have made the PR from the wrong branch 🙄 This was to fix the language selection issue, and I've used the incomplete android UI branch. will push the rest of the changes and update this PR, and make a new one for the language..

mark-prins commented 2 years ago

Is it possible to not auto capitalize "Site name" and password in the bootstrap screen?

haven't been able to reproduce this! for me, neither field have autocapitalised 🤷 However, have added the input hint to prevent it 😁

This PR is incomplete, right? e.g. Adding item modal for inbound shipments need similar change...

Not sure about this one either - the inbound shipment is already done

Once we got the reliable build system going we should remove the .so files from the repo, think it blows up the repo quite a bit...

yes! this was just a helper really, so that f/e devs could build and test easily 😁

clemens-msupply commented 2 years ago

Thanks autocapitalised is disabled now on my device