msupply-foundation / unified-codes

Provides a curated, searchable list of pharmaceutical products, each with an immutable code. A GraphQL API, a REST API and website are available for interaction with the database.
https://codes.msupply.foundation
2 stars 0 forks source link

NZULM item links do not work #349

Open RowenaN opened 3 years ago

RowenaN commented 3 years ago

The NZULM link from the product pages work - but not from the individual items. Below screenshot shows the page for product amoxicillin

image

NZULM uses script to open a window which displays the individual item and codes (using MT button on above screen) - so a link is not possible. Example with same web address (the 104 number is the one for the 250cap but the webaddress is unchanged):

image

Expected Behaviour

When clicking on an item NZULM code, should open the product page (or there should be no link). The link on the NZULM product page should not be changed. Screenshot shows web page looking for NZULM item code for Amoxicillin 250mg capsule and subsequent error message.

Current Behaviour

If you click on the current link for items, you will be given an error message image

Possible Solution

As above - either link to the product page or remove link entirely.

Steps to Reproduce (bugs only, delete if not applicable)

As above

wlthomson commented 3 years ago

Confirmed can replicate this.

Not an expert on NZULM, but it looks like this might be caused by incorrect NZULM codes?

E.g. our NZULM code for acetazolamide is 10203911000116105 (https://search.nzulm.org.nz/search/product?table=MP&id=10203911000116105). From cross-referencing with the NZULM website, it looks like the correct code is 10203891000116107 (https://search.nzulm.org.nz/search/product?id=10203891000116107&table=MP).

Update: just for reference, the code for amoxicillin looks like it should be 20023151000116107 (https://search.nzulm.org.nz/search/product?id=20023151000116107&table=MP).

RowenaN commented 3 years ago

NZULM is like UC in that it has a different code for the product and item.

Product: Amoxicillin has the NZULM code 202315100116107 - the NZULM MP code Item: Amoxicillin 250mg cap has the NZULM code 202315100116104 - the NZULM MPUU code

The problem is to get to the NZULM MPUU code (e.g. Amoxicillin 250mg cap), you need to first go to the product (Amoxicillin)and then click on the MT button. I don't think you can link to the window that opens when you press the MT button.

kat-ms commented 3 years ago

Potentially dodgy (as NZULM can technically change their site anytime they want) but it looks like if needed we could kludge together a link to the MPUU page: