Closed jmbrunskill closed 7 months ago
Also need to make product properties work, as they should be included in mSupply too...
Oh good call - do you mean that product field is used in mSupply? Are you intending to include that in this PR as well or a separate piece of work?
we do this entities query for all items for the fuzzy search - especially as we add more items I can imagine this query getting slow?
Yeah, it definitely doesn't feel great. Could compare speed to using a loader for all properties? Still seems fast locally on good hardware, but I agree! Maybe an issue for the future?
Oh good call - do you mean that product field is used in mSupply? Are you intending to include that in this PR as well or a separate piece of work?
Was going to do this in the same PR, but since it's approved, I'll merge this and do the other in a new one.
Fixes #605
Description
The dgraph backend
entities
query was deliberately kept minimal to avoid having huge dgraph requests just to get product names, however the mSupply query is asking for properties.Now returns:
Checklist:
-[ ] Also need to make product properties work, as they should be included in mSupply too...
Tests:
Tick below if one of the following applies: