search

msurdi / frontend-dependencies

Copies node packages to a directory where your frontend tools will be able to find them
24 stars 5 forks source link

Add more help. #14

Closed ve3 closed 5 years ago

ve3 commented 5 years ago

Not all users are familiar with command line. So, add a bit more help message can make their life easier. However postinstall in scripts did not run with npm install command. ( https://stackoverflow.com/questions/31000392/npm-how-to-just-run-post-install ). This need a little more describe to tell user how to make this script work.

FelixFurtmayr commented 5 years ago

thank you!

the test is failing as external files in the required turbolinks repo have changed. Can you include the following correction in your pull request, so the test will pass?

File: /test/test2/package.json

      "turbolinks": {
          "url": "git://github.com/turbolinks/turbolinks.git#a720d93",  // <= I used an older version here
          "src": "{src,LICENSE}",
          "target": "static/build/turbo"
      }

You can test it, if npm test works on your local comupter.

ve3 commented 5 years ago

I do not understand, I just add few lines of text to describe more in readme.md but why /test/test2/package.json? And I have no idea how to do that? Edit test file (what changed?) and pull request again?

FelixFurtmayr commented 5 years ago

sorry for my bad explanation; change just this line: "url": "git://github.com/turbolinks/turbolinks.git", => "url": "git://github.com/turbolinks/turbolinks.git#a720d93",

then "npm test" should pass for you. Then commit the stuff again - should be added here again to the pull request and the test should pass.

ve3 commented 5 years ago

npm test

'mocha' is not recognized as an internal or external command, operable program or batch file. npm ERR! Test failed. See above for more details.

This seems too difficult for me.