search

msurdi / frontend-dependencies

Copies node packages to a directory where your frontend tools will be able to find them
24 stars 5 forks source link

Fix test and npm issues #15

Closed FelixFurtmayr closed 5 years ago

FelixFurtmayr commented 5 years ago

@msurdi test was fixed, the issue of ve3 solved and his changes from the pull request he closed were added to the readme. please review and merge. thank you.

FelixFurtmayr commented 5 years ago

oh - and a npm publish would be nice after the merge, so we can use the improved version. Thank you :-)

msurdi commented 5 years ago

Just published frontend-dependencies@1.1.7

@FelixFurtmayr Do you have an username at npmjs.com? If so, I'd like to give yo permissions to publish, just in case I'm not available and to avoid a single point of failure :-).

FelixFurtmayr commented 5 years ago

I'm not sure if I already have the right to publish on npm? Anyway - my name on npm is felix_furtmayr. Do I have the right on github to approve merge requests? Would be also nice. Although we would stick to the schema we did (I might write something, you do a review), if it does not bother you.

msurdi commented 5 years ago

@FelixFurtmayr sorry for my late answer, I've just confirmed you do have permissions to publish on NPM and to merge PRs as well. I'm happy to follow the current workflow too. Just wanted to confirm you're not blocked if for some reason I'm not available. Thanks for your great work!.