search

msurguy / Honeypot

Simple spam prevention package for Laravel applications
maxoffsky.com/code-blog/implementing-honeypot-spam-prevention-in-laravel-applications/
MIT License
429 stars 44 forks source link

Added required package illuminate/html #34

Closed sdebacker closed 9 years ago

sdebacker commented 9 years ago

But this package is deprecated… It would be nice to remove this dependency.

garygreen commented 9 years ago

Technically it's not required, could update the service provider to not add the honeypot macro to the form builder if it doesn't exist. You can still instantiate honeypot manually and get the html (or use the honeypot facade). All the illuminate/html would be for is to add a macro honeypot to the FormBuilder which is more of a shortcut/usage preference, not worth forcing users to load it imo. I'm -1 to this PR, though might be useful to add it in a suggests section.

As for Laravel Collective, I think it's not currently supported, though you can use the Honeypot facade for now.

sdebacker commented 9 years ago

Ok, you are right.

sdebacker commented 9 years ago

I finally created my own package based on this one : https://github.com/TypiCMS/Honeypot

garygreen commented 9 years ago

PR #35 will solve this issue so not really necessary to maintain another package but fair enough.

msurguy commented 9 years ago

This package has been updated now to 1.0.0 version.

sdebacker commented 9 years ago

Thank you Maksim, I deleted my fork !