msv-lab / modus

A language for building Docker/OCI container images
GNU Affero General Public License v3.0
279 stars 9 forks source link

`::set_entrypoint`: resolve relative path? #118

Closed maowtm closed 2 years ago

maowtm commented 2 years ago

i.e.

from("alpine")::set_workdir("/usr/src/app")::set_entrypoint("app")

should set entrypoint to /usr/src/app/app

maowtm commented 2 years ago

Just realized that docker simply use the entrypoint as execp argument (which has PATH resolution), so that simply by saying ENTRYPOINT ["sh", ...] would work for invoking shell. This means that we probably should leave it as-is and not change the semantic of entrypoint. They can always specify ./exe anyway...