Expand readme; remove unused reference to BeautifulSoup

mswhirl / autoflashgui

Utility to flash firmware to modems and run setup commands after the flash has completed

GNU General Public License v3.0

70 stars 17 forks source link

Expand readme; remove unused reference to BeautifulSoup #1

Closed davidjb closed 5 years ago

davidjb commented 6 years ago

A few small improvements:

In the Readme: add instructions for running from source. It was already pretty self-evident but this adds the info into the readme.
In the GUI script: simplify imports (bs4 isn't used)

Thanks for the effort in making this great tool!

davidjb commented 5 years ago

@mswhirl Any thoughts on this PR?

mswhirl commented 5 years ago

Done, thanks for updating the PR for the library. I apologise for the delay - I didn't get an email when you originally put it in (it must have been spam filtered) otherwise it would have been done long ago :)

Thanks for contributing!

davidjb commented 5 years ago

All good, thanks for merging!

I think you might need to add yourself to watching the repo to get notified (https://github.com/mswhirl/autoflashgui/watchers) -- I've never been clear what happens on Github repos one owns, particularly with PRs to those repos, so tend to just add myself to anyway just in case.