search

mswhirl / autoflashgui

Utility to flash firmware to modems and run setup commands after the flash has completed
GNU General Public License v3.0
70 stars 17 forks source link

Support generic variants and reorganize defaults #24

Closed LuKePicci closed 4 years ago

LuKePicci commented 4 years ago

Please check if all edits make sense

bovirus commented 4 years ago

@mswhirl

For me it's better to have clear oattaern for mdoem name in the list. For me could be better to use the same name scheme. Like

DGA 4130 (TIM) 1.0.3 etc DGA 4132 (TIM) 1.0.3 etc

I didn't udnerstand why he add the product code (AGTEF or AGTHP). The name (4130/4132) for me is enough. For me the list could be

DGA4130 (TIM) 1.0.3 (root) DGA4132 (TIM) 1.0.3 (passive root and Basic DDNS) DGA4132 (TIM) 1.0.3 (root and Advanced DDNS) DGA4132 (TIM) 1.0.3 (root and Basic DDNS) TG789vac v2 iiNet 16.3 (root)

Clear and simple.

LuKePicci commented 4 years ago

AGTEF_1.0.3 is firmware version, not product code

bovirus commented 4 years ago

@LujkePicci

The firmware version is 1.0.3. The internal product code is AGTEF (4130) or AGTHP (4132). If you refer to TIM you refer to AGTEF/AGTHP. It's a double info.

LuKePicci commented 4 years ago

Nope, the version string for TIM is AGTEF_1.0.3. It is the same for Telstra 18.1.c.0215-950-RA The naming adhere to the same exact standard: <isp> <software_version>

You can check version strings in the TIM gateways if you like,, it is under Device.DeviceInfo.SoftwareVersion

bovirus commented 4 years ago

As I mentioned AGTEF if product name for TIM for 4130 as AGTHP is 4132.

If you already mentioned TIM in the name AGTEF and AGTHP are not necessary.

Is not available a TIM firmware for 4130 that is not AGTEF. And the same for DGA4132 and AGTHP.

If you want use as name TIM AGTEF/AGTHP don't use 4130/4132 in the name. DGA 4130/4132 are Technicolor name. TIM AGTEF/AGTHP are TIM name.

LuKePicci commented 4 years ago

Let's try again. AGTEF_1.0.3 is the version string reported in the firmware. I don't know why dumb people working for TIM used their product name in firmware version, but that's what they did. The caption does not show AGTEF to indicate the product, it shows AGTEF1.0.3 because that's the version string. Think to fastweb firmwares, they includes "FW" as prefix which stands for "fastweb" for each firmware version. We would still use FW_249 as firmware version string, even if we already used "Fastweb" in "Fastweb FW249" and FW is always fastweb and so redundant.

LuKePicci commented 4 years ago

Is not available a TIM firmware for 4130 that is not AGTEF. And the same for DGA4132 and AGTHP.

Actually there are some AGTEF series firmwares for 4132...

bovirus commented 4 years ago

Then please leave original lines for DGA 4130 and DGA 4132 for Technicolor modes. For most of common users using AGTEF or AGTHP in firmware info don't add important info and only can create misunderstanding about real firmware version. For most of them firmware version is 1.0.3. Not AGTEF_1.0.3.

AGTEF and AGTHP are different board then I believe that are not available official AGTEF firmware for AGTHP board and viceversa.

LuKePicci commented 4 years ago

Nope, let's adhere to a standard naming which matches vendor decisions. Use complete SoftwareVersion as defined and we all would be happy.

Also, we are just talking of a couple of presets that are superseded by the generic ones, it's more likely you will see them disappear.

LuKePicci commented 4 years ago

You may notice there are some TG799 preset names I didn't fixed, that's because I have no evidence of what exact device/firmware they relates to. I didn't investigate further because it is better to directly remove them once we know they're no more needed.