search

mswhirl / autoflashgui

Utility to flash firmware to modems and run setup commands after the flash has completed
GNU General Public License v3.0
70 stars 17 forks source link

Add support for rooting Telstra TG799vac on 17.2+ #3

Closed davidjb closed 5 years ago

davidjb commented 5 years ago

This roots the modem on latest/newer firmware versions where the previous Ping/DDNS command injections were patched. This uses the basic dynamic DNS page in much the same way as the DDNS did; Telstra or Technicolor seem to have just omitted fixing the issue in the basic DDNS lua file. This means the tediousness of reflashing firmware can be avoided -- just flash to 17.2 and root.

Also included is a minor GUI change, adding the mention of the "DDNS Basic" command injection process in addition to DDNS and Ping options.

Tested a few times on TG799vac modem running firmware vant-f_CRF852-17.2.0261-820-RA.rbi (with factory-reset in between tests).

davidjb commented 5 years ago

@mswhirl Something I wanted your input on -- these 17.2 firmwares have fw upgrading disabled through the Lua scripts. Once you have root, changing the gateway-modal.lp file is easy, but it could also be done automatically during rooting. I'm not fussed either way -- it's easy enough to patch later with:

sed -i -e 's/currentuserrole == "guest"/true/g' /www/docroot/modals/gateway-modal.lp
sed -i -e 's/post_helper.isUpgradeAllowed(cui.upgradefw, currentuserrole)/true/g' /www/docroot/modals/gateway-modal.lp
/etc/init.d/nginx restart

If you think that should be part of the 17.2 rooting, then I'm sure it'd be a helpful addition to anyone flashing to these versions.

mswhirl commented 5 years ago

Yet again the notifications did not work. I have changed my email address and notification settings and hopefully they will work now. Ironically I redid the investigation today that you obviously did 15 days ago :( Please check if your pull request is still warranted (and check the WP wiki - scripts all updated). Cheers, Mark.

davidjb commented 5 years ago

All good, great minds thinking alike. Hopefully notifications are working now.

Your new changes negate the need for this PR now but what of my comment above (https://github.com/mswhirl/autoflashgui/pull/3#issuecomment-445457774)? So once 17.2+ is uploaded and installed, you can't use this tool or the GUI for further firmware upgrades (or downgrades) until you patch the lua code. It's easy enough to do by hand but if you thought it helpful to be part of the 'core' root method, I could see that being helpful to others.

I'll close this PR but leave the rest of that up to you.