search

mswift42 / theme-creator

create emacs 24 themes.
GNU General Public License v3.0
226 stars 7 forks source link

'preset' dropdown is confusing and can clobber my changes #4

Open akkartik opened 9 years ago

akkartik commented 9 years ago

After I'd made some changes to the theme I tried opening both dialogs to see what was in them. I didn't realize that I still had the cursor inside the 'preset' dialog, and lost my changes when I hit an arrow key.

mswift42 commented 9 years ago

Do you have any suggestions how to solve this problem?

akkartik commented 9 years ago

I've seen some websites warn when you try to navigate away with unsubmitted changes. Maybe we could do something like that? It's not exactly navigation away though so I'm not sure how to implement that idea. Web dev isn't my strong suit, honestly.

Or you could temporarily save current settings when navigating away from 'presets'.

We don't typically think of changing a dropdown as something committal. So maybe just replace the dropdown with things that look like buttons or links?

The quick-n-dirty solution before working on something better: move the 'presets' dropdown to a separate place, label it better so it's clear what it does without clicking on it, add a warning in red that it will clobber changes.

That's what I have :) Thanks for this tool!