mswift42 / themecreator

https://mswift42.github.io/themecreator/ create themes for intellij, textmate, textadept, atom, emacs, vim and gnome terminal.
GNU General Public License v3.0
404 stars 33 forks source link

Inital implementation of theme template for TextAdept #19

Closed paaguti closed 2 years ago

paaguti commented 2 years ago

Hi

Although my main editor is Emacs, I include TextAdept in the lab environments I'm responsible for. The editor is located at: https://github.com/orbitalquark/textadept if you don't now it.

I hope I didn't forget anything. I tried to test on a Ubuntu focal VM, but I need to get used to Clojure I fear...

/PA

mswift42 commented 2 years ago

First of all, this looks really fantastic, thank you very much.

One question though, I installed textadept, created a themes folder in ~/.textadept/themes, copied my theme into the folder, but calling set_theme just results in a "attempt to call a nil value" error.

What am I doing wrong?

paaguti commented 2 years ago

Hi,

nothing like a good night's sleep... Could you please try this PR? I think I have fixed everything.

As I told you, I would like to be able to create a VM with all I need to create a local copy of the site to develop on. Could you pelase help me with this?

Best, /PA

PS: tested on Textadept 11.4 nightly on Linux

mswift42 commented 2 years ago

to run themecreator locally you only need firefox or chrome, bash, curl, rlwrap and java. Then install clojure as detailed here: install clojure on linux https://clojure.org/guides/getting_started#_installation_on_linux. Then clone the repo , go into the app.core directory and run clj -M:fig:build.

For a better emacs experience have a look at cider https://github.com/clojure-emacs/cider.

Also, check out figwheel-main https://figwheel.org/, which themecreator uses for a nice development experience.

Martin

On Mon, 7 Mar 2022 at 07:38, Pedro A. Aranda Gutiérrez < @.***> wrote:

Hi,

nothing like a good night's sleep... Could you please try this PR. I think I have fixed everything. As I told you, I would like to be able to create a VM with all I need to create a local copy of the site to develop on.

Best, /PA

— Reply to this email directly, view it on GitHub https://github.com/mswift42/themecreator/pull/19#issuecomment-1060276533, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARK7OQKHIYCCO47TR3EGFTU6WW7JANCNFSM5QAYHWMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

paaguti commented 2 years ago

Sure :-) Done

Enviado desde mi iPhone

El 7 mar 2022, a las 9:35, Martin Haesler @.***> escribió:

 @mswift42 commented on this pull request.

In app.core/resources/public/templates/textadept.txt:

-;; Author: {{themeauthor}} -;; Version: 0.1 -;; Package-Requires: ((emacs "24")) -;; Created with ThemeCreator, https://github.com/mswift42/themecreator. +-- Author: {{themeauthor}} +-- Version: 0.1 +-- Package-Requires: ((emacs "24")) You still require emacs here. You probably want to delete this line.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

mswift42 commented 2 years ago

When I try one of my themes copied into the themes directory I still get this error:

lua: /usr/local/share/textadept/init.lua:31: attempt to call a nil value

and the theme fails to load.

here is the generated theme in question

paaguti commented 2 years ago

Hi, Thanks for the generated theme. That's why I'll continue working on getting a GUI-less VM with themecreator running. Meanwhile, silkwork-lua has been very helpful. I've uploaded the next set of patches.

best, /PA PS: silkworm looks extremely nice on TextAdept :-)

On Mon, 7 Mar 2022 at 14:00, Martin Haesler @.***> wrote:

When I try one of my themes copied into the themes directory I still get this error:

lua: /usr/local/share/textadept/init.lua:31: attempt to call a nil value

and the theme fails to load.

here is the generated theme in question https://gist.github.com/mswift42/15fc34ef595c357be8bc15dd0f7a6bb0

— Reply to this email directly, view it on GitHub https://github.com/mswift42/themecreator/pull/19#issuecomment-1060660824, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZKU4AEZY52YBXN6RQGYL3U6X4V3ANCNFSM5QAYHWMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler

mswift42 commented 2 years ago

now it fails with

lua: /home/martin/.textadept/themes/silkworm.lua:89: bad argument #2 to 'set_sel_fore' (number expected, got string)

paaguti commented 2 years ago

Hmm?? I got your silkworm.lua, fixed it and then transposed the changes to the template...

Can you please check the attached file on your TextAdept ?

Best, /PA

On Mon, 7 Mar 2022 at 15:21, Martin Haesler @.***> wrote:

now it fails with

lua: /home/martin/.textadept/themes/silkworm.lua:89: bad argument #2 https://github.com/mswift42/themecreator/issues/2 to 'set_sel_fore' (number expected, got string)

— Reply to this email directly, view it on GitHub https://github.com/mswift42/themecreator/pull/19#issuecomment-1060738312, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZKU4CGJFCDUSR3WD56JBDU6YGFNANCNFSM5QAYHWMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler

mswift42 commented 2 years ago

What attached file?

On Mon, 7 Mar 2022 at 17:01, Pedro A. Aranda Gutiérrez < @.***> wrote:

Hmm?? I got your silkworm.lua, fixed it and then transposed the changes to the template...

Can you please check the attached file on your TextAdept ?

Best, /PA

On Mon, 7 Mar 2022 at 15:21, Martin Haesler @.***> wrote:

now it fails with

lua: /home/martin/.textadept/themes/silkworm.lua:89: bad argument #2 https://github.com/mswift42/themecreator/issues/2 to 'set_sel_fore' (number expected, got string)

— Reply to this email directly, view it on GitHub < https://github.com/mswift42/themecreator/pull/19#issuecomment-1060738312>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAZKU4CGJFCDUSR3WD56JBDU6YGFNANCNFSM5QAYHWMA

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

You are receiving this because you authored the thread.Message ID: @.***>

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler

— Reply to this email directly, view it on GitHub https://github.com/mswift42/themecreator/pull/19#issuecomment-1060911711, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARK7OSE253CKGOWUDPTLZTU6YY7BANCNFSM5QAYHWMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

paaguti commented 2 years ago

Oops, sorry I thought you could get the attachment from my gmail. Let's try from here:

silkworm.zip

Uncompress in themes directly... BTW, which version of TextAdept are you testing on?

mswift42 commented 2 years ago

I'm using Textadept 11.3

with your provided file silkworm.lua, I'm still getting this error message:

lua: /home/martin/.textadept/themes/silkworm.lua:89: bad argument #2 to

'set_sel_fore' (number expected, got string)

Martin

On Tue, 8 Mar 2022 at 06:16, Pedro A. Aranda Gutiérrez < @.***> wrote:

Oops, sorry I thought you could get the attachment from my gmail. Let's try from here:

silkworm.zip https://github.com/mswift42/themecreator/files/8203195/silkworm.zip

Uncompress in themes directly... BTW, which version of TextAdept are you testing on?

— Reply to this email directly, view it on GitHub https://github.com/mswift42/themecreator/pull/19#issuecomment-1061446997, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARK7OQZRLRDPJEUZJI7JX3U63WFFANCNFSM5QAYHWMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

paaguti commented 2 years ago

Strange... This is the theme file with a minimalistic init.lua

ta-silkworm

And this is a pre-release of 11.3. on a Linux. A pity too, because it really looks pretty :-)

Tried on macOS and Windows (stock 11.3 from https://github.com/orbitalquark/textadept) and it looks as pretty as in Linux. Could you please recheck versions? I'm quite puzzled here ... /PA

paaguti commented 2 years ago

After all the tests, Consolas looks much better in Windows than Courier New ;-)

mswift42 commented 2 years ago

Could you supply me with a minimalist init.lua with which it works?

On Wed, 9 Mar 2022 at 07:19, Pedro A. Aranda Gutiérrez < @.***> wrote:

After all the tests, Consolas looks much better in Windows than Courier New ;-)

— Reply to this email directly, view it on GitHub https://github.com/mswift42/themecreator/pull/19#issuecomment-1062623038, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARK7OSTSXF2HPXLCBNBF4TU7BGHRANCNFSM5QAYHWMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

mswift42 commented 2 years ago

I can load the silkworm theme if I have view:set_theme("silkworm") in my init.lua.

However, starting textadept, opening command entry and then calling set_theme 'silkworm' will fail with the afore mentioned error message

lua: /home/martin/.textadept/themes/silkworm.lua:89: bad argument #2 to 'set_sel_fore' (number expected, got string)

paaguti commented 2 years ago

Hi,

AFAIK, the only correct way of setting a theme is through view:set_theme(). The old set_theme() way was deprecated some time ago. Let me check on the TextAdept list.

On Wed, 9 Mar 2022 at 15:00, Martin Haesler @.***> wrote:

I can load the silkworm theme if I have view:set_theme("silkworm") in my init.lua.

However, starting textadept, opening command entry and then calling set_theme 'silkworm' will fail with the afore mentioned error message

lua: /home/martin/.textadept/themes/silkworm.lua:89: bad argument #2 to 'set_sel_fore' (number expected, got string)

— Reply to this email directly, view it on GitHub https://github.com/mswift42/themecreator/pull/19#issuecomment-1062949195, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZKU4DUDSGAIVTEHYUUY53U7CVGDANCNFSM5QAYHWMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler

paaguti commented 2 years ago

OK, I could change the colour definitions from using strings to using numbers but then we need a way to translate numbers: "#RRGGBB" needs to be translated to 0xBBGGRR. How difficult would that be? /PA

On Thu, 10 Mar 2022 at 07:15, Pedro Andres Aranda Gutierrez < @.***> wrote:

Hi,

AFAIK, the only correct way of setting a theme is through view:set_theme(). The old set_theme() way was deprecated some time ago. Let me check on the TextAdept list.

On Wed, 9 Mar 2022 at 15:00, Martin Haesler @.***> wrote:

I can load the silkworm theme if I have view:set_theme("silkworm") in my init.lua.

However, starting textadept, opening command entry and then calling set_theme 'silkworm' will fail with the afore mentioned error message

lua: /home/martin/.textadept/themes/silkworm.lua:89: bad argument #2 to 'set_sel_fore' (number expected, got string)

— Reply to this email directly, view it on GitHub https://github.com/mswift42/themecreator/pull/19#issuecomment-1062949195, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZKU4DUDSGAIVTEHYUUY53U7CVGDANCNFSM5QAYHWMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler

mswift42 commented 2 years ago

Conversing rrggbb to 0xbbggrr would be quite trivial to do. I can write a clojure function to call before compiling the template tomorrow. You have to delete the string quotation marks in the textadept template though.

On Thu, Mar 10, 2022, 06:29 Pedro A. Aranda Gutiérrez < @.***> wrote:

OK, I could change the colour definitions from using strings to using numbers but then we need a way to translate numbers: "#RRGGBB" needs to be translated to 0xBBGGRR. How difficult would that be? /PA

On Thu, 10 Mar 2022 at 07:15, Pedro Andres Aranda Gutierrez < @.***> wrote:

Hi,

AFAIK, the only correct way of setting a theme is through view:set_theme(). The old set_theme() way was deprecated some time ago. Let me check on the TextAdept list.

On Wed, 9 Mar 2022 at 15:00, Martin Haesler @.***> wrote:

I can load the silkworm theme if I have view:set_theme("silkworm") in my init.lua.

However, starting textadept, opening command entry and then calling set_theme 'silkworm' will fail with the afore mentioned error message

lua: /home/martin/.textadept/themes/silkworm.lua:89: bad argument #2 to 'set_sel_fore' (number expected, got string)

— Reply to this email directly, view it on GitHub < https://github.com/mswift42/themecreator/pull/19#issuecomment-1062949195>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAZKU4DUDSGAIVTEHYUUY53U7CVGDANCNFSM5QAYHWMA

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

You are receiving this because you authored the thread.Message ID: @.***>

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler

— Reply to this email directly, view it on GitHub https://github.com/mswift42/themecreator/pull/19#issuecomment-1063709860, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARK7OWNQMRL4IN22DLATZLU7GJDFANCNFSM5QAYHWMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

paaguti commented 2 years ago

Will do during the weekend. Would your function include the 0x at the beginning?

//PA

Enviado desde mi iPhone

El 10 mar 2022, a las 12:51, Martin Haesler @.***> escribió:

 Conversing rrggbb to 0xbbggrr would be quite trivial to do. I can write a clojure function to call before compiling the template tomorrow. You have to delete the string quotation marks in the textadept template though.

On Thu, Mar 10, 2022, 06:29 Pedro A. Aranda Gutiérrez < @.***> wrote:

OK, I could change the colour definitions from using strings to using numbers but then we need a way to translate numbers: "#RRGGBB" needs to be translated to 0xBBGGRR. How difficult would that be? /PA

On Thu, 10 Mar 2022 at 07:15, Pedro Andres Aranda Gutierrez < @.***> wrote:

Hi,

AFAIK, the only correct way of setting a theme is through view:set_theme(). The old set_theme() way was deprecated some time ago. Let me check on the TextAdept list.

On Wed, 9 Mar 2022 at 15:00, Martin Haesler @.***> wrote:

I can load the silkworm theme if I have view:set_theme("silkworm") in my init.lua.

However, starting textadept, opening command entry and then calling set_theme 'silkworm' will fail with the afore mentioned error message

lua: /home/martin/.textadept/themes/silkworm.lua:89: bad argument #2 to 'set_sel_fore' (number expected, got string)

— Reply to this email directly, view it on GitHub < https://github.com/mswift42/themecreator/pull/19#issuecomment-1062949195>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAZKU4DUDSGAIVTEHYUUY53U7CVGDANCNFSM5QAYHWMA

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

You are receiving this because you authored the thread.Message ID: @.***>

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler

— Reply to this email directly, view it on GitHub https://github.com/mswift42/themecreator/pull/19#issuecomment-1063709860, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARK7OWNQMRL4IN22DLATZLU7GJDFANCNFSM5QAYHWMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

mswift42 commented 2 years ago

Yes

On Fri, Mar 11, 2022, 07:15 Pedro A. Aranda Gutiérrez < @.***> wrote:

Will do during the weekend. Would your function include the 0x at the beginning?

//PA

Enviado desde mi iPhone

El 10 mar 2022, a las 12:51, Martin Haesler @.***> escribió:

 Conversing rrggbb to 0xbbggrr would be quite trivial to do. I can write a clojure function to call before compiling the template tomorrow. You have to delete the string quotation marks in the textadept template though.

On Thu, Mar 10, 2022, 06:29 Pedro A. Aranda Gutiérrez < @.***> wrote:

OK, I could change the colour definitions from using strings to using numbers but then we need a way to translate numbers: "#RRGGBB" needs to be translated to 0xBBGGRR. How difficult would that be? /PA

On Thu, 10 Mar 2022 at 07:15, Pedro Andres Aranda Gutierrez < @.***> wrote:

Hi,

AFAIK, the only correct way of setting a theme is through view:set_theme(). The old set_theme() way was deprecated some time ago. Let me check on the TextAdept list.

On Wed, 9 Mar 2022 at 15:00, Martin Haesler @.***> wrote:

I can load the silkworm theme if I have view:set_theme("silkworm") in my init.lua.

However, starting textadept, opening command entry and then calling set_theme 'silkworm' will fail with the afore mentioned error message

lua: /home/martin/.textadept/themes/silkworm.lua:89: bad argument

2 to

'set_sel_fore' (number expected, got string)

— Reply to this email directly, view it on GitHub <

https://github.com/mswift42/themecreator/pull/19#issuecomment-1062949195>,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAZKU4DUDSGAIVTEHYUUY53U7CVGDANCNFSM5QAYHWMA

. Triage notifications on the go with GitHub Mobile for iOS <

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android <

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.

You are receiving this because you authored the thread.Message ID: @.***>

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler

— Reply to this email directly, view it on GitHub < https://github.com/mswift42/themecreator/pull/19#issuecomment-1063709860>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AARK7OWNQMRL4IN22DLATZLU7GJDFANCNFSM5QAYHWMA

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

— Reply to this email directly, view it on GitHub https://github.com/mswift42/themecreator/pull/19#issuecomment-1064839319, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARK7OQZHNCO74AK3EFZVIDU7LXHFANCNFSM5QAYHWMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

mswift42 commented 2 years ago

I've merged these into the master branch.

paaguti commented 2 years ago

OK, then. I'll fix the template tomorrow early (CET) /PA

On Fri, 11 Mar 2022 at 08:19, Martin Haesler @.***> wrote:

Yes

On Fri, Mar 11, 2022, 07:15 Pedro A. Aranda Gutiérrez < @.***> wrote:

Will do during the weekend. Would your function include the 0x at the beginning?

//PA

Enviado desde mi iPhone

El 10 mar 2022, a las 12:51, Martin Haesler @.***> escribió:

 Conversing rrggbb to 0xbbggrr would be quite trivial to do. I can write a clojure function to call before compiling the template tomorrow. You have to delete the string quotation marks in the textadept template though.

On Thu, Mar 10, 2022, 06:29 Pedro A. Aranda Gutiérrez < @.***> wrote:

OK, I could change the colour definitions from using strings to using numbers but then we need a way to translate numbers: "#RRGGBB" needs to be translated to 0xBBGGRR. How difficult would that be? /PA

On Thu, 10 Mar 2022 at 07:15, Pedro Andres Aranda Gutierrez < @.***> wrote:

Hi,

AFAIK, the only correct way of setting a theme is through view:set_theme(). The old set_theme() way was deprecated some time ago. Let me check on the TextAdept list.

On Wed, 9 Mar 2022 at 15:00, Martin Haesler @.***> wrote:

I can load the silkworm theme if I have view:set_theme("silkworm") in my init.lua.

However, starting textadept, opening command entry and then calling set_theme 'silkworm' will fail with the afore mentioned error message

lua: /home/martin/.textadept/themes/silkworm.lua:89: bad argument

2 to

'set_sel_fore' (number expected, got string)

— Reply to this email directly, view it on GitHub <

https://github.com/mswift42/themecreator/pull/19#issuecomment-1062949195 ,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAZKU4DUDSGAIVTEHYUUY53U7CVGDANCNFSM5QAYHWMA

. Triage notifications on the go with GitHub Mobile for iOS <

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android <

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.

You are receiving this because you authored the thread.Message ID: @.***>

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler

— Reply to this email directly, view it on GitHub < https://github.com/mswift42/themecreator/pull/19#issuecomment-1063709860 , or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AARK7OWNQMRL4IN22DLATZLU7GJDFANCNFSM5QAYHWMA

. Triage notifications on the go with GitHub Mobile for iOS <

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android <

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.

You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

— Reply to this email directly, view it on GitHub < https://github.com/mswift42/themecreator/pull/19#issuecomment-1064839319>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AARK7OQZHNCO74AK3EFZVIDU7LXHFANCNFSM5QAYHWMA

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/mswift42/themecreator/pull/19#issuecomment-1064841590, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZKU4BGT3JCQKUBETJ7ZIDU7LXWFANCNFSM5QAYHWMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler