search

mswift42 / themecreator

https://mswift42.github.io/themecreator/ create themes for intellij, textmate, textadept, atom, emacs, vim and gnome terminal.
GNU General Public License v3.0
404 stars 33 forks source link

Issues WIth MELPA Submission #26

Closed SamuelBanya closed 1 year ago

SamuelBanya commented 2 years ago

I am in pending status for the 'morrowind-emacs-theme' related theme I created with 'themecreator' on MELPA aka the Emacs based package site itself: https://github.com/melpa/melpa/pull/8095

These are the issues that were generated as a result of the 'themecreator' itself, but I'm not sure how I can fix this because this is as a result of 'themecreator' itself:

8 issues found:
1:0: error: Package should have a Homepage or URL header.
1:0: warning: The word "emacs" is redundant in Emacs package names.
26:0: error: Package should have a non-empty ;;; Commentary section.
250:8: warning: Closing parens should not be wrapped onto new lines.
266:3: warning: Closing parens should not be wrapped onto new lines.

Including this here in case anyone like myself wants to use this tool to make themes for MELPA, and wants to get approved.

Please let me know if there is anything within the 'themecreator' code base that could be revised accordingly, thanks.

mswift42 commented 2 years ago

Hi, thank you for opening this issue.

You can find the emacs template in the templates folder here.

Please feel free to clone this repo, adapt the emacs template to fit with the current melpa package codestyle and send a pull request.

mswift42 commented 1 year ago

Closing this now because of a lack of response.

SamuelBanya commented 1 year ago

@mswift42 Please check the merge request here: https://github.com/mswift42/themecreator/pull/33