Open d4v3y5c0n3s opened 1 year ago
Below is the result of calling the "diff" command on two themes that I've made using ThemeCreator for Textadept. The "DoctorJones" theme is a slightly older theme that works, and "BananaNotebook" is a more recent theme that doesn't work.
1c1
< --- BananaNotebook.lua
---
> --- DoctorJones.lua
27,44c27,44
< colors.fg1 = 0x311f24
< colors.fg2 = 0x413136
< colors.fg3 = 0x524347
< colors.fg4 = 0x625559
< colors.bg1 = 0xf4f5f6
< colors.bg2 = 0xe0e1e2
< colors.bg3 = 0xcdcecf
< colors.bg4 = 0xb9babb
< colors.builtin = 0x2c4563
< colors.keyword = 0x3c5e86
< colors.const = 0x2d1da5
< colors.comment = 0x96999a
< colors.func = 0x5161f6
< colors.str = 0x48a3ff
< colors.type = 0x46383d
< colors.var = 0x6bf0f9
< colors.warning = 0x11c2f5
< colors.warning2 = 0x281cc0
---
> colors.fg1 = 0x000000
> colors.fg2 = 0x141414
> colors.fg3 = 0x292929
> colors.fg4 = 0x3d3d3d
> colors.bg1 = 0x718ba4
> colors.bg2 = 0x688097
> colors.bg3 = 0x5f758a
> colors.bg4 = 0x566a7d
> colors.builtin = 0x311f24
> colors.keyword = 0x46383d
> colors.const = 0xd4d4d4
> colors.comment = 0x0046c6
> colors.func = 0x0aa5e5
> colors.str = 0xb7221c
> colors.type = 0x7ad133
> colors.var = 0xd4d4d4
> colors.warning = 0x2d1da5
> colors.warning2 = 0x1066b0
92,93c92,93
< -- view:set_sel_fore(true, colors.fg2)
< view:set_sel_back(true, colors.selection)
---
> view:set_sel_fore(true, colors.fg3)
> view:set_sel_back(true, colors.bg3)
96,97c96,97
< view.caret_line_back = colors.bg4
< view.caret_line_back_alpha = 50
---
> view.caret_line_back = colors.bg2
> --view.caret_line_back_alpha =
I was able to successfully get a different broken them I had made recently working by changes the lines 92, 93, 96 & 97 to match the ones present in the working theme (DoctorJones.) I'm unfamiliar with Clojure, but nontheless I'll investigate the source code and if I find a solution I'll make a pull request to fix the issue.
Hi Troy,
There is no need to learn clojure. The relevant theme templates are stored as text files in the templates https://github.com/mswift42/themecreator/tree/master/app.core/resources/public/templates folder.
On Thu, 1 Jun 2023 at 09:58, Troy Jacobs @.***> wrote:
Below is the result of calling the "diff" command on two themes that I've made using ThemeCreator for Textadept. The "DoctorJones" theme is a slightly older theme that works, and "BananaNotebook" is a more recent theme that doesn't work. 1c1 < --- BananaNotebook.lua
--- DoctorJones.lua 27,44c27,44 < colors.fg1 = 0x311f24 < colors.fg2 = 0x413136 < colors.fg3 = 0x524347 < colors.fg4 = 0x625559 < colors.bg1 = 0xf4f5f6 < colors.bg2 = 0xe0e1e2 < colors.bg3 = 0xcdcecf < colors.bg4 = 0xb9babb < colors.builtin = 0x2c4563 < colors.keyword = 0x3c5e86 < colors.const = 0x2d1da5 < colors.comment = 0x96999a < colors.func = 0x5161f6 < colors.str = 0x48a3ff < colors.type = 0x46383d < colors.var = 0x6bf0f9 < colors.warning = 0x11c2f5 < colors.warning2 = 0x281cc0
colors.fg1 = 0x000000 colors.fg2 = 0x141414 colors.fg3 = 0x292929 colors.fg4 = 0x3d3d3d colors.bg1 = 0x718ba4 colors.bg2 = 0x688097 colors.bg3 = 0x5f758a colors.bg4 = 0x566a7d colors.builtin = 0x311f24 colors.keyword = 0x46383d colors.const = 0xd4d4d4 colors.comment = 0x0046c6 colors.func = 0x0aa5e5 colors.str = 0xb7221c colors.type = 0x7ad133 colors.var = 0xd4d4d4 colors.warning = 0x2d1da5 colors.warning2 = 0x1066b0 92,93c92,93 < -- view:set_sel_fore(true, colors.fg2) < view:set_sel_back(true, colors.selection)
view:set_sel_fore(true, colors.fg3) view:set_sel_back(true, colors.bg3) 96,97c96,97 < view.caret_line_back = colors.bg4 < view.caret_line_back_alpha = 50
view.caret_line_back = colors.bg2 --view.caret_line_back_alpha =
I was able to successfully get a different broken them I had made recently working by changes the lines 92, 93, 96 & 97 to match the ones present in the working theme (DoctorJones.) I'm unfamiliar with Clojure, but nontheless I'll investigate the source code and if I find a solution I'll make a pull request to fix the issue.
— Reply to this email directly, view it on GitHub https://github.com/mswift42/themecreator/issues/34#issuecomment-1571636451, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARK7OWYWBRQIHVAGBXEEDLXJBKUXANCNFSM6AAAAAAYVW2WKQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Thanks for the info, I've created a pull request which fixes this issue.
Hey, I have added a couple more things in preparation textadept 12. Bad summer and even worse transition from the 'kids@TA' ;-)
(I'm using Textadept version 11.4 on Linux) I've used this tool in the past to make themes for Textadept without issue, but there appears to be an issue at the moment where the "Textadept" theme option is not working correctly. I've provided a screenshot showing the errors being produced when I try to use a theme. I still have themes that I've made using this tool in the past which continue to work for me. I'll look further into this, and please feel free to ask me any questions you may have.![textadept_error_messages](https://github.com/mswift42/themecreator/assets/46783356/0dc1ed11-91b5-4b4b-8f0c-c4322d155abe)