search

mswift42 / themecreator

https://mswift42.github.io/themecreator/ create themes for intellij, textmate, textadept, atom, emacs, vim and gnome terminal.
GNU General Public License v3.0
404 stars 33 forks source link

Doesn't appear to be compatible with terminal-only editors #5

Closed ErikBoesen closed 6 years ago

ErikBoesen commented 6 years ago

I've tried to use a vim theme created with ThemeCreator in my terminal, but since only guifg/guibg properties are specified in themes output, the theme has no effect.

Color hex codes can be converted to xterm-256 colors pretty easily. I found this Python package to do it.

Let me know if I can help with this.

mswift42 commented 6 years ago

Which terminal are you using ?

ErikBoesen commented 6 years ago

iTerm2. (I also tested with the standard macOS Terminal.app.)

ErikBoesen commented 6 years ago

Do other terminals support GUI colors? I admittedly don't know.

mswift42 commented 6 years ago

Do you have the line

set termguicolors set in your .vimrc ?

I

mswift42 commented 6 years ago

Iterm2 also has true color support.

See here:

True Colour support in Terminals

ErikBoesen commented 6 years ago

Ah, adding that does fix it! Thank you!

Still, don't you think ThemeCreator should provide 256color codes by default? Again this is not my area of expertise so feel free to close this if that doesn't seem useful.

mswift42 commented 6 years ago

I don't think it's important anymore, because all mainstream (and most non mainstream) terminals now support true colours.

ErikBoesen commented 6 years ago

Okay, that's fair. Thanks for your help!

mswift42 commented 6 years ago

No worries.

ErikBoesen commented 6 years ago

Sorry to revive this issue again; do you think it might be reasonable to automatically execute set termguicolors in generated themes?

mswift42 commented 6 years ago

No, that would mean overriding a users config, and I don't want to do that.

I'll add an entry to the README though.

ErikBoesen commented 6 years ago

Makes sense!