mswjs / examples

Examples of Mock Service Worker usage with various frameworks and libraries.
683 stars 211 forks source link

add a separate "with-jest-jsdom" example #100

Closed VanTanev closed 9 months ago

VanTanev commented 9 months ago

Jest without JSDOM is simpler to run and does not require undici patching.

Closes #99

kettanaito commented 9 months ago

Thanks for opening this, @VanTanev! I left a few comments, will address them once I have a minute.

kettanaito commented 9 months ago

I renamed the example, added it to the CI, elaborated more on what and why to do in its README. This should be good now, let's see the tests!

VanTanev commented 9 months ago

Oops, I guess removing ts-node was too optimistic - although it did run OK locally?

kettanaito commented 9 months ago

@VanTanev, it ran okay locally because other examples used ts-node, I suppose. On CI, each example only installs its own dependencies.

VanTanev commented 9 months ago

@kettanaito Thank you!