Handle errors in the interceptor handler

[mikicho]

Following this comment.

Problem: this line throws when an error occurs in the handler. This prevents the user from handling errors with error listener in the request, which causes this test to fail.

I think it's because we currently don't catch the promise, we only handle the then case.

[kettanaito]

Hi. Have you tried using Response.error() instead of throwing in the request listener?

until() works as try/catch so exceptions in its closure will also propagate to the .then() callback as result.error.

[mikicho]

Hi. Have you tried using Response.error() instead of throwing in the request listener?

Yes, it converts the error to a generic Network error, which is not what we are after.

until() works as try/catch so exceptions in its closure will also propagate to the .then() callback as result.error.

Interesting, this is not what I see, the code never gets to the then clause, I'll try to reproduce it in a small script without Nock's noise.

[mikicho]

Update: it seems like it's working as expected when I isolated the scenario in a small script. I'll keep updating my findings and close this ticket if needed.

[mikicho]

My mistake. For reference, if you use a promise, reject it instead of throw an error:

interceptor.on('request', function ({ request, requestId }) {
  return new Promise((resolve, reject) => {
     throw error; // not working
     reject(error) // good
  })
});