search

mswjs / msw-storybook-addon

Mock API requests in Storybook with Mock Service Worker.
https://msw-sb.vercel.app
MIT License
408 stars 39 forks source link

chore: update all stories to CSF hoisted format #28

Closed yannbf closed 3 years ago

yannbf commented 3 years ago

This PR updates the stories files (as well as tests and documentation examples) to use hoisted CSF annotation which is the standard format since Storybook 6.

yannbf commented 3 years ago

Thank you for isolating these changes, @yannbf! Do we need to bump the storybook peer dependency, or are these changes compatible with the current version of @storybook/addons?

Actually the hoisted CSF annotation was introduced in Storybook 6 and the project used 6.1 so it's all good! Storybook is also backwards compatible in that syntax, but it will likely be deprecated in future versions.

Still, Storybook is currently at 6.2 so I could also upgrade it.

kettanaito commented 3 years ago

Thanks for the answer!

Still, Storybook is currently at 6.2 so I could also upgrade it.

Feel free to open a new pull request for that update.