mswjs / msw-storybook-addon

Mock API requests in Storybook with Mock Service Worker.
https://msw-sb.vercel.app
MIT License
408 stars 39 forks source link

Add typescript support #61

Closed yannbf closed 2 years ago

yannbf commented 3 years ago

Migration to typescript.

Seems like MSW does not export all the types we need so a Typescript workaround was necessary. @kettanaito care to give some assistance? <3

The way this is seems good to me too. It's not really necessary to export those types from msw, although it would be nice!

Closes #38

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mswjs/msw-storybook-addon/opJ7vu8uqUfuKWZwpW8ne9YhuLAw
✅ Preview: https://msw-storybook-addon-git-feature-typescript-migration-mswjs.vercel.app

kettanaito commented 3 years ago

Hey, @yannbf. Thank you for these improvements! I've rebased the feature branch and pushed some minor changes. Please let me know if those align with your intention here.

yannbf commented 3 years ago

Thanks a lot @kettanaito! I worked through your feedback and this is ready to be reviewed once again!