search

mswjs / msw-storybook-addon

Mock API requests in Storybook with Mock Service Worker.
https://msw-sb.vercel.app
MIT License
408 stars 39 forks source link

dep: expand msw peer dependency version range #76

Closed yannbf closed 2 years ago

yannbf commented 2 years ago

Issue: #74

This PR proposes the following approach: Set MSW as a peer dependency from 0.35 and higher minor versions.

The idea is that MSW is a peer dependency and will be managed by the users, which might want to try out new features and will always end up hitting a roadblock with this addon. In case MSW does release a breaking change as a minor, we will have to deal with it in the addon, which might be a good thing because it will force a faster evolution/sync of the addon

Thoughts @kettanaito ?

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mswjs/msw-storybook-addon/3rHUAEZ5H6fwTJAbYdup9L4KgBfY
✅ Preview: https://msw-storybook-addon-git-feat-update-msw-dependency-mswjs.vercel.app

kettanaito commented 2 years ago

Hey, @yannbf. Thanks for making this happen.

In case MSW does release a breaking change as a minor, we will have to deal with it in the addon,

I'd treat minor MSW versions as those that contain breaking changes since we're in the pre 1.0 phase. That being said, the next minor versions won't automatically get installed when installing dependencies, so it will be a conscious user choice.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.6.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: