fix: parse "Set-Cookie" response header with commas correctly

mswjs / msw

Industry standard API mocking for JavaScript.

https://mswjs.io

MIT License

15.98k stars 520 forks source link

fix: parse "Set-Cookie" response header with commas correctly #2075

Closed ushiboy closed 8 months ago

ushiboy commented 8 months ago

Closes https://github.com/mswjs/msw/issues/2074

Fixed to handle Set-Cookies containing commas. If TypeScript is 5.2 or higher, getSetCookie in Headers can be used, but this has been fixed as a temporary measure at this time.

see also:

https://developer.mozilla.org/en-US/docs/Web/API/Headers/getSetCookie
https://github.com/microsoft/TypeScript/issues/55270

ushiboy commented 8 months ago

@kettanaito I have added a comment granting an explanation. Please check again.

kettanaito commented 8 months ago

Welcome to the contributors, @ushiboy! 👏

kettanaito commented 8 months ago

Released: v2.2.4 🎉

This has been released in v2.2.4!

📄 Release notes
📦 npm package

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.