search

mswjs / msw

Seamless REST/GraphQL API mocking library for browser and Node.js.
https://mswjs.io
MIT License
15.28k stars 479 forks source link

docs: fix readme badges underline #2152

Closed dnicolson closed 1 month ago

dnicolson commented 1 month ago

Before: PixelSnap 2024-05-15 at 00 06 20@2x

After: PixelSnap 2024-05-15 at 00 08 01@2x

kettanaito commented 1 month ago

Hi, @dnicolson. Can you please tell me more about what this actually changes? I did my best to A/B your screenshots and code but they look identical to me. Thanks.

dnicolson commented 1 month ago

On WebKit/Blink browsers empty whitespace in an anchor tag results in an underline.

Removing the whitespace fixes this.

franky47 commented 1 month ago

The before tags have better vertical alignment of the text inside the tag IMHO.

kettanaito commented 1 month ago

@franky47, that looks like some rendering shenanigans. Looks okay if you open the feature branch.

kettanaito commented 1 month ago

Released: v2.3.1 🎉

This has been released in v2.3.1!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.