search

mswjs / msw

Industry standard API mocking for JavaScript.
https://mswjs.io
MIT License
15.97k stars 519 forks source link

fix: update `@inquirer/confirm` to 4.0 #2300

Closed greysteil closed 1 month ago

greysteil commented 1 month ago

The only change between v3 and v4 is allowing the prefix for the confirm message to be changed, which msw doesn't use. (Alternatively we could widen the supported range here to ^3.0.0 || ^4.0.0, but it looks like msw generally specifies a single major version it supports.)

The main benefit of the change will be to get access to https://github.com/SBoudrias/Inquirer.js/pull/1569 once it lands (or to make it easier to do so if that is released in a new major version). That will reduce development build size for lots of apps which are currently getting two versions of @types/node due to this dependency.

kettanaito commented 1 month ago

Hi, @greysteil 👋 Thanks for submitting this. I think this looks great.

kettanaito commented 1 month ago

Publishing it as a fix. No user-facing changes present.

kettanaito commented 1 month ago

Released: v2.4.13 🎉

This has been released in v2.4.13!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.

ravicious commented 1 month ago

It looks like we still need one more bump to @inquirer/confirm@5.0.0 which depends on @inquirer/core@10.0.0 which no longer has @types/node in deps. Compare dep graphs for 4.0.1 and 5.0.0.

kettanaito commented 1 month ago

@ravicious sounds good. Pull requests are welcome!

greysteil commented 1 month ago

All yours @ravicious (or I'll take it if you're busy)

ravicious commented 1 month ago

I have to yield as I don't have enough free time at work to take care of this, but I do appreciate your effort!

greysteil commented 1 month ago

Done in https://github.com/mswjs/msw/pull/2325