Added accountId to SummonerDto

msx752 / RiotGamesAPI

[outdated] LeagueOfLegends API Library .NetCore

https://riotgamesapi.readme.io

MIT License

2 stars 1 forks source link

Added accountId to SummonerDto #4

Closed sigr3s closed 6 years ago

sigr3s commented 6 years ago

AccountId is added to SummonerDto as Match-V3 needs this attribute in the following calls: -/lol/match/v3/matchlists/by-account/{accountId} -/lol/match/v3/matchlists/by-account/{accountId}/recent

msx752 commented 6 years ago

thank you @sigr3s but i dont understand to link with matchlists

i think this is not for match api but summoner api results ?

/lol/summoner/v3/summoners/by-account/{accountId}
/lol/summoner/v3/summoners/by-name/{summonerName}
/lol/summoner/v3/summoners/{summonerId}

btw, next time please create a PR to the develop branch ;)

sigr3s commented 6 years ago

Sorry about creating PR to master.

You are right this value is returned in the summoner api results. But you may need this attribute from this calls to make the match api ones.