Closed naveen521kk closed 1 year ago
Locally the smoke tests successfully passed:
It looks like you need some newer updates from 3.10 branches, at least f1755b79446155ce23a8f2f9f810b08cbeea9d2a and 3f5fc0093ec9d26a78df331129f56cc849313673 to allow the cross-llvm-mingw jobs to run.
It looks like you need some newer updates from 3.10 branches, at least https://github.com/msys2-contrib/cpython-mingw/commit/f1755b79446155ce23a8f2f9f810b08cbeea9d2a and https://github.com/msys2-contrib/cpython-mingw/commit/3f5fc0093ec9d26a78df331129f56cc849313673 to allow the cross-llvm-mingw jobs to run.
Thanks, will cherry-pick and squash it. Also, I don't they will succeed since it requires a "build python" for cross-compiling now https://docs.python.org/3/using/configure.html#cross-compiling-options.
edit: will squash later, probably all the CI config into a single commit
Also, I don't they will succeed since it requires a "build python" for cross-compiling now https://docs.python.org/3/using/configure.html#cross-compiling-options.
I think there is already provision for providing a compatible python version for the build system (the deadsnakes ppa thing), it'd probably just need to add the configure option.
hopefully we won't need to set winjitdebug
anymore, @lazka's testing showed 3.11 didn't have that mystery issue
https://gist.github.com/naveen521kk/19d01c3841a98bd7890aaaa94f6657b2
Once it is ready for review, would a range-diff against the latest 3.10 branch be helpful here (like on msys2-runtime updates), or would there be too much 'noise' from Setup-related moves?
Once it is ready for review, would a range-diff against the latest 3.10 branch be helpful here (like on msys2-runtime updates), or would there be too much 'noise' from Setup-related moves?
I've updated the description with range-diff
. The setup-related move could have added some 'noise', but it should be readable ig. I'll also update it when I make any changes here.
@@ mingw_smoketests.py (new) + helloworld(PyObject *self, PyObject *args) + { + printf("Hello World\\n"); -+ Py_RETURN_NONE; ++ return Py_None; + } + static PyMethodDef + myMethods[] = {
I think this was a fix that got reverted? (specifically https://github.com/msys2-contrib/cpython-mingw/pull/130)
I think this was a fix that got reverted? (specifically https://github.com/msys2-contrib/cpython-mingw/pull/130)
It wasn't reverted, I started working on this before that commit and missed cherry-picking it. Thanks, will cherry-pick now!
I think most of the work here is done, I've also updated the description with the range-diff.
venvs are broken for the installed version at least (which is a bit of a blocker):
$ python3.11 -m venv _foooo2
Error: Command '['C:/msys64/home/user/_foooo2/bin/python3.11.exe', '-m', 'ensurepip', '--upgrade', '--default-pip']' returned non-zero exit status 1.
$ C:/msys64/home/user/_foooo2/bin/python3.11.exe
Could not find platform independent libraries <prefix>
Could not find platform dependent libraries <exec_prefix>
Python path configuration:
PYTHONHOME = (not set)
PYTHONPATH = (not set)
program name = 'C:\msys64\home\user\_foooo2\bin\python3.11.exe'
isolated = 0
environment = 1
user site = 1
safe_path = 0
import site = 1
is in build tree = 0
stdlib dir = 'D:/M/msys64/ucrt64/lib/python3.11'
sys._base_executable = 'C:/msys64/home/user/_foooo2/bin/python3.11.exe'
sys.base_prefix = 'D:/M/msys64/ucrt64'
sys.base_exec_prefix = 'D:/M/msys64/ucrt64'
sys.platlibdir = 'lib'
sys.executable = 'C:/msys64/home/user/_foooo2/bin/python3.11.exe'
sys.prefix = 'D:/M/msys64/ucrt64'
sys.exec_prefix = 'D:/M/msys64/ucrt64'
sys.path = [
'D:/M/msys64/ucrt64/lib/python311.zip',
'D:/M/msys64/ucrt64/lib/python3.11',
'D:/M/msys64/ucrt64/lib/python3.11/lib-dynload',
]
Fatal Python error: init_fs_encoding: failed to get the Python codec of the filesystem encoding
Python runtime state: core initialized
ModuleNotFoundError: No module named 'encodings'
Current thread 0x00004124 (most recent call first):
<no Python frame>
hopefully we won't need to set
winjitdebug
anymore, @lazka's testing showed 3.11 didn't have that mystery issue
@jeremyd2019 I can confirm that the meson crashes are gone with this update: https://github.com/lazka/python-crash-test/actions/runs/5368625876
venvs are broken for the installed version at least (which is a bit of a blocker):
I think bringing back https://github.com/msys2-contrib/cpython-mingw/issues/90 would be a simple way to fix this issue. I'll have a look.
venvs are broken for the installed version at least (which is a bit of a blocker):
This should be fixed now, I've made https://github.com/msys2/MINGW-packages/pull/17644
fyi, I tried to rebase on top of 3.11.4: there are no conflicts, but https://github.com/python/cpython/commit/09ce8c3b48f940eb8865330f029b8069854c3106 is needed to make the tests pass. maybe it helps.
I'll merge this and then work on 3.11.4 on a new PR.
https://gist.github.com/naveen521kk/19d01c3841a98bd7890aaaa94f6657b2
git range-diff v3.10.12...mingw-v3.10.12 v3.11.2...wip-mingw-v3.11.2
``` 1: 72cb22a255 = 1: ee7014656b sysconfig: make _sysconfigdata.py relocatable 2: e5355d722a < -: ---------- restore setup config 3: 0e78138b41 ! 2: 529a549c50 build: add --with-nt-threads and make it default on mingw @@ Metadata ## Commit message ## build: add --with-nt-threads and make it default on mingw + Co-authored-by: Naveen M K